[23289] Handle maximum deadline misses case (backport #6016) #6097

mergify · 2025-10-10T11:03:54Z

Description

This PR fixes an issue where a DataWriter with a deadline period of 0ms would cause a high CPU load due to an infinite loop of deadline_missed callbacks.

The DataWriterImpl has been modified to handle a 0 as a special case. When this condition is detected:

A single warning is logged.
The deadline_missed_status_.total_count and deadline_missed_status_.total_count_change are set to INT_MAX as a sentinel value.

This ensures that the DataWriter remains stable and responsive, and allows the deadline timer to be properly re-armed if the QoS is later changed to a valid value.
Also, reaching the maximal number of deadline missed messages cancels the timer.

Fixes #23289

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[N/A] Any new/modified methods have been properly documented using Doxygen.
[N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
[N/A] New feature has been added to the versions.md file (if applicable).
[N/A] New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #6016 done by [Mergify](https://mergify.com).

mergify · 2025-10-10T11:03:56Z

Cherry-pick of 3230d1d has failed:

On branch mergify/bp/2.14.x/pr-6016
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 3230d1d7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/fastdds/subscriber/DataReaderImpl.hpp
	modified:   test/blackbox/api/dds-pim/PubSubReader.hpp
	modified:   test/blackbox/api/dds-pim/PubSubWriter.hpp
	new file:   test/utils/LogCounter.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/fastdds/publisher/DataWriterImpl.cpp
	both modified:   src/cpp/fastdds/publisher/DataWriterImpl.hpp
	both modified:   src/cpp/fastdds/subscriber/DataReaderImpl.cpp
	both modified:   test/blackbox/CMakeLists.txt
	both modified:   test/blackbox/common/BlackboxTestsDeadlineQos.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

juanlofer-eprosima · 2025-10-10T11:22:42Z

@zesk1999 please solve conflicts here

src/cpp/fastdds/subscriber/DataReaderImpl.cpp

test/blackbox/common/BlackboxTestsDeadlineQos.cpp

mergify · 2025-10-14T18:56:25Z

🧪 CI Insights

Here's what we observed from your CI run for 7fd176c.

❌ Job Failures

Pipeline	Job	Health on `2.14.x`	Retries	🔍 CI Insights	📄 Logs
`Fast-DDS MacOS CI`	`mac-ci / reusable-mac-ci (RelWithDebInfo)`		`0`	View	View

test/blackbox/CMakeLists.txt

* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp # src/cpp/fastdds/publisher/DataWriterImpl.hpp # src/cpp/fastdds/subscriber/DataReaderImpl.cpp # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsDeadlineQos.cpp

juanlofer-eprosima

LGTM

* Refs #23289. Handle maximum deadline misses case. Data writer implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Data reader implementation. Signed-off-by: zesk1999 <zesk1999@gmail.com> * Refs #23289. Handle maximum deadline misses case. Tests. Signed-off-by: zesk1999 <zesk1999@gmail.com> --------- Signed-off-by: zesk1999 <zesk1999@gmail.com> (cherry picked from commit 3230d1d) Signed-off-by: zesk1999 <zesk1999@gmail.com> Co-authored-by: Zeljko Jovanovic <128973134+zesk1999@users.noreply.github.com>

mergify bot added the conflicts Backport PR wich git cherry pick failed label Oct 10, 2025

mergify bot mentioned this pull request Oct 10, 2025

[23289] Handle maximum deadline misses case #6016

Merged

12 tasks

juanlofer-eprosima added this to the v2.14.6 milestone Oct 10, 2025

fujitatomoya mentioned this pull request Oct 11, 2025

The CPU usage is still high without data forwarding eProsima/DDS-Pipe#146

Closed

zesk1999 requested a review from juanlofer-eprosima October 14, 2025 05:07

juanlofer-eprosima removed the conflicts Backport PR wich git cherry pick failed label Oct 14, 2025

juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 14, 2025 07:38

github-actions bot added the ci-pending PR which CI is running label Oct 14, 2025

juanlofer-eprosima requested changes Oct 14, 2025

View reviewed changes

src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated Show resolved Hide resolved

test/blackbox/common/BlackboxTestsDeadlineQos.cpp Outdated Show resolved Hide resolved

juanlofer-eprosima requested changes Oct 14, 2025

View reviewed changes

test/blackbox/common/BlackboxTestsDeadlineQos.cpp Outdated Show resolved Hide resolved

zesk1999 force-pushed the mergify/bp/2.14.x/pr-6016 branch from 973535e to ccfb5d5 Compare October 14, 2025 08:20

zesk1999 requested a review from juanlofer-eprosima October 14, 2025 08:22

zesk1999 force-pushed the mergify/bp/2.14.x/pr-6016 branch from ccfb5d5 to 3d5bccd Compare October 14, 2025 13:46

zesk1999 requested review from juanlofer-eprosima and removed request for juanlofer-eprosima October 14, 2025 13:49

juanlofer-eprosima requested changes Oct 15, 2025

View reviewed changes

test/blackbox/CMakeLists.txt Outdated Show resolved Hide resolved

test/blackbox/CMakeLists.txt Outdated Show resolved Hide resolved

test/blackbox/CMakeLists.txt Show resolved Hide resolved

zesk1999 force-pushed the mergify/bp/2.14.x/pr-6016 branch from 3d5bccd to dbd3e05 Compare October 15, 2025 07:05

zesk1999 requested review from juanlofer-eprosima and removed request for juanlofer-eprosima October 15, 2025 07:08

zesk1999 force-pushed the mergify/bp/2.14.x/pr-6016 branch 2 times, most recently from 2f72993 to 5c2753d Compare October 15, 2025 10:55

zesk1999 requested review from juanlofer-eprosima and removed request for juanlofer-eprosima October 15, 2025 10:56

zesk1999 force-pushed the mergify/bp/2.14.x/pr-6016 branch from 5c2753d to 7fd176c Compare October 15, 2025 14:34

zesk1999 requested a review from juanlofer-eprosima October 15, 2025 14:37

zesk1999 removed the request for review from juanlofer-eprosima October 15, 2025 14:37

juanlofer-eprosima approved these changes Oct 16, 2025

View reviewed changes

juanlofer-eprosima merged commit 404c0e3 into 2.14.x Oct 16, 2025
18 of 19 checks passed

juanlofer-eprosima deleted the mergify/bp/2.14.x/pr-6016 branch October 16, 2025 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[23289] Handle maximum deadline misses case (backport #6016) #6097

[23289] Handle maximum deadline misses case (backport #6016) #6097

Uh oh!

mergify bot commented Oct 10, 2025

Uh oh!

mergify bot commented Oct 10, 2025

Uh oh!

juanlofer-eprosima commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanlofer-eprosima left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[23289] Handle maximum deadline misses case (backport #6016) #6097

[23289] Handle maximum deadline misses case (backport #6016) #6097

Uh oh!

Conversation

mergify bot commented Oct 10, 2025

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

mergify bot commented Oct 10, 2025

Uh oh!

juanlofer-eprosima commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mergify bot commented Oct 14, 2025 •

edited

Loading